Use constant value in imag implementation for real-valued data types#2063
Merged
ndgrigorian merged 2 commits intomasterfrom Apr 29, 2025
Merged
Use constant value in imag implementation for real-valued data types#2063ndgrigorian merged 2 commits intomasterfrom
imag implementation for real-valued data types#2063ndgrigorian merged 2 commits intomasterfrom
Conversation
ndgrigorian
requested review from
antonwolfy,
vlad-perevezentsev and
vtavana
as code owners
ndgrigorian
force-pushed
the
use-constant-value-in-imag
branch
from
6cae791 to
eb8d305
Compare
antonwolfy
previously approved these changes
Apr 28, 2025
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
LGTM! Thank you @ndgrigorian, just a small nit below
ndgrigorian
force-pushed
the
use-constant-value-in-imag
branch
from
eb8d305 to
79d4e9f
Compare
antonwolfy
approved these changes
Apr 28, 2025
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_165 ran successfully. |
ndgrigorian
force-pushed
the
use-constant-value-in-imag
branch
from
79d4e9f to
b909228
Compare
Collaborator
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_169 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to add a
constant_valueof 0 to be used by the implementation of the element-wise kernel when the input is a real-valued data typeSlips in change to use
is_complex_vinimagandreal